Package the jar analyzers #5290
Conversation
ugras-ergun-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
| @@ -1550,9 +1550,13 @@ | |||
| "Microsoft.VisualStudio.Interop": "17.0.31902.203" | |||
| } | |||
| }, | |||
| "copydependencies": { | |||
There was a problem hiding this comment.
why is it lower case here?
|
|
||
| <Target Name="CopyJars"> | ||
| <ItemGroup> | ||
| <SourceJars Include="$(JarDownloadDir)\sonar-cfamily-plugin-$(EmbeddedSonarCFamilyAnalyzerVersion).jar" /> |
There was a problem hiding this comment.
Could we somehow centralize the list of dependencies between this and DownloadDependencies task? Currently, if we ever add another analyzer, we would need to modify these 2 targets + EmbeddedSonarAnalyzer.props file
There was a problem hiding this comment.
I'll add another ticket for this and we can tackle it if we have time in this sprint or we can handle it in a hardening sprint.
| @@ -286,7 +286,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <Content Include="DownloadedJars\*.jar"> | |||
| <CopyToOutputDirectory>Never</CopyToOutputDirectory> | |||
There was a problem hiding this comment.
Did it not work without this?
There was a problem hiding this comment.
or rather with this
This reverts commit c164af4.
|
ugras-ergun-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
| <ItemGroup Label="Sloop Dependencies"> | ||
| <Content Include="$(MSBuildThisFileDirectory)$(JarsFolderName)\*.jar"> | ||
| <IncludeInVSIX>True</IncludeInVSIX> | ||
| <VSIXSubPath>$(JarsFolderName)</VSIXSubPath> |
There was a problem hiding this comment.
Is this somehow related?
There was a problem hiding this comment.
I don't see how these can be related. The one you referred is about loading assemblies, we are not interested in that here.
| @@ -1533,6 +1533,9 @@ | |||
| "Microsoft.VisualStudio.Interop": "17.0.31902.203" | |||
| } | |||
| }, | |||
| "copydependencies": { | |||
There was a problem hiding this comment.
Why is it lowercase?
There was a problem hiding this comment.
no idea it's auto generated.
There was a problem hiding this comment.
Some other stuff is also lowercase (e.g. "sonarqube.client"). Since it doesn't affect anything other than cosmetics on an auto-generated file I don't consider it as a problem.
|
|
||
| <Target Name="CopyJars"> | ||
| <ItemGroup> | ||
| <SourceJars Include="$(JarDownloadDir)\sonar-cfamily-plugin-$(EmbeddedSonarCFamilyAnalyzerVersion).jar" /> |
There was a problem hiding this comment.
Will this fail if it can't find any of those files?
There was a problem hiding this comment.
Yes, and I believe it's desired behaviour.
Fixes #5283